| From: | Nikhil Kumar Veldanda <veldanda(dot)nikhilkumar17(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Burd, Greg" <greg(at)burd(dot)me>, Nikita Malakhov <hukutoc(at)gmail(dot)com>, Hannu Krosing <hannuk(at)google(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem) |
| Date: | 2026-01-05 07:39:28 |
| Message-ID: | CAFAfj_GLv5yTOk8q94-uU8+uJeAQDW26SrYOGWWs-=Ej7j1QFg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 4, 2026 at 2:23 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
>
> One thing that stands out for me is that I am going to need the oid8
> data type anyway, to be store the 8-byte values in the catalogs, with
> a C type to mark some of the TOAST apis with it across the board, so I
> would like to apply that to move this part out of the way (0001 only)
> and move the needle. If there are any objections to that, please feel
> free.
>
Hi Michael,
Two quick notes from my review:
Semantics: the regression test accepts '-1040' and wraps modulo 2^64.
Is that intentional? If yes, please document it; if not, oid8in()
should reject negative input and the test should expect an error.
Nits: oid8.c appears to include <ctype.h> / <limits.h> without using
them, and there’s an empty src/test/regress/expected/oid8.sql
(intentional?).
--
Nikhil Veldanda
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-01-05 07:40:45 | RE: Parallel Apply |
| Previous Message | Prafulla Ranadive | 2026-01-05 07:24:31 | Re: Need help with postgresql build on windows |