| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |
| Date: | 2025-12-19 20:02:12 |
| Message-ID: | aUWvRKmVWJsNxKX5@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 12, 2025 at 11:17:01AM -0500, Tom Lane wrote:
> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)kurilemu(dot)de> writes:
> > It's strange to see this thread go on about messing with the Perl script
> > because we're too afraid of pg_bsd_indent. Maybe we should take
> > ownership of that code -- improve its own indentation to our
> > conventions, add comments, rename unclear variables, and so on until we
> > have something we can work with, and fix these weird bugs and
> > idiosincratic behaviors we don't like. I just found out this code dates
> > back from 1976.
>
> I've worked with that code a little bit, and it's mostly unreadable
> spaghetti :-(. If somebody wants to make an effort to make it not
> so awful, that'd be great, but I fear it's a very nontrivial project.
Yes, this is why we had to wrap the pg_bsd_indent call in Perl.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2025-12-19 21:09:47 | Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) |
| Previous Message | David G. Johnston | 2025-12-19 19:10:56 | Re: Get rid of "Section.N.N.N" on DOCs |