| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |
| Date: | 2025-12-12 16:17:01 |
| Message-ID: | 1000974.1765556221@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)kurilemu(dot)de> writes:
> It's strange to see this thread go on about messing with the Perl script
> because we're too afraid of pg_bsd_indent. Maybe we should take
> ownership of that code -- improve its own indentation to our
> conventions, add comments, rename unclear variables, and so on until we
> have something we can work with, and fix these weird bugs and
> idiosincratic behaviors we don't like. I just found out this code dates
> back from 1976.
I've worked with that code a little bit, and it's mostly unreadable
spaghetti :-(. If somebody wants to make an effort to make it not
so awful, that'd be great, but I fear it's a very nontrivial project.
Having said that, we've already basically forked it from the NetBSD
upstream, so there is no reason not to diverge further.
> We have a _huge_ regression test for it: our own source code repository.
> It's not like any breakage is going to go unnoticed.
True.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-12-12 16:23:14 | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |
| Previous Message | Mahendra Singh Thalor | 2025-12-12 16:17:00 | Re: Non-text mode for pg_dumpall |