Re: Fix memory leak in gist_page_items() of pageinspect

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix memory leak in gist_page_items() of pageinspect
Date: 2025-12-19 10:26:55
Message-ID: aUUob2r26L1JCaSJ@ip-10-97-1-34.eu-west-3.compute.internal
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Fri, Dec 19, 2025 at 05:36:51PM +0800, Japin Li wrote:
> On Fri, 19 Dec 2025 at 08:23, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> > Yeah that would not hurt. What about before the relation_open() calls?
> >
> > "
> > Use relation_open() and not index_open() to avoid the validate_relation_kind()
> > check as we handle relation validation separately below.
> > "
> >
>
> LGTM.

Thanks! Done that way in the attached.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v3-0001-Use-relation_close-more-consistently.patch text/x-diff 3.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2025-12-19 11:05:31 Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Previous Message Amit Kapila 2025-12-19 10:18:21 Re: Orphaned records in pg_replication_origin_status after subscription drop