| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect |
| Date: | 2025-12-19 11:05:31 |
| Message-ID: | CAHGQGwFQZoKd-d3WjODmEgemPqPmehGdRiTQx7pez2R9_UKCQg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 19, 2025 at 7:07 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
> Thanks for the patch — that was my oversight.
>
> LGTM with one small suggestion:
Thanks for the review!
> The comment says: "If the option is not found in connInfo, return NULL value."
>
> Since the parameter is named `keyword`, I'd suggest: "If the keyword is not found in connInfo, return NULL."
>
> This keeps terminology consistent with the function signature.
I think "the option with the given keyword" is more precise than just
"the keyword".
That said, simply using "the option" also seems sufficient in this context...
Regarding 0002 patch, I found that it caused a CI failure, so I’ve updated
the patch to fix that. The revised patch is attached.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-PG15-PG16-Honor-GUC-settings-specified-in-CREATE-SUBSCRIPTI.txt | text/plain | 5.6 KB |
| v6-0002-Add-TAP-test-for-GUC-settings-passed-via-CONNECTI.patch | application/octet-stream | 3.1 KB |
| v6-0001-Honor-GUC-settings-specified-in-CREATE-SUBSCRIPTI.patch | application/octet-stream | 5.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2025-12-19 11:35:27 | Re: Logical Replication of sequences |
| Previous Message | Bertrand Drouvot | 2025-12-19 10:26:55 | Re: Fix memory leak in gist_page_items() of pageinspect |