Re: Extended Statistics set/restore/clear functions.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, jian he <jian(dot)universality(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Extended Statistics set/restore/clear functions.
Date: 2025-12-08 01:25:45
Message-ID: aTYpGfoSuRGTjJnG@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 05, 2025 at 12:30:38AM -0500, Corey Huinker wrote:
> Attached is a follow-on to Michael's most recent uncommitted patch,
> changing the errors that I see as "impossible" to elogs. However, I agree
> that they don't add significant workload to the translations, and most
> input functions need to avoid any hard error returns lest they be called in
> a soft-error context.

Reporting the state of the parser in these new elogs is OK for me, but
we had more cases that what your patch has been updating. I have
included all these cases, making the set of error messages a bit more
consistent across the board, and applied the result.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message torikoshia 2025-12-08 01:26:33 Re: Enhancing Memory Context Statistics Reporting
Previous Message Chao Li 2025-12-08 01:20:00 Re: Fix incorrect comments in tuplesort.c