| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, jian he <jian(dot)universality(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Extended Statistics set/restore/clear functions. |
| Date: | 2025-12-11 21:52:26 |
| Message-ID: | CADkLM=cFrhE76jnqPZz4pBjyA97qfYkDqWUpw1PK7HEfWB+H4w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Dec 7, 2025 at 8:26 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Dec 05, 2025 at 12:30:38AM -0500, Corey Huinker wrote:
> > Attached is a follow-on to Michael's most recent uncommitted patch,
> > changing the errors that I see as "impossible" to elogs. However, I agree
> > that they don't add significant workload to the translations, and most
> > input functions need to avoid any hard error returns lest they be called
> in
> > a soft-error context.
>
> Reporting the state of the parser in these new elogs is OK for me, but
> we had more cases that what your patch has been updating. I have
> included all these cases, making the set of error messages a bit more
> consistent across the board, and applied the result.
> --
> Michael
>
Rebased. Used new palloc0_array() in a few places, and fixed an expected
output message that wasn't updated to reflect the changes.
| Attachment | Content-Type | Size |
|---|---|---|
| v21-0001-Expose-attribute-statistics-functions-for-use-in.patch | text/x-patch | 30.9 KB |
| v21-0002-Add-extended-statistics-support-functions.patch | text/x-patch | 103.3 KB |
| v21-0003-Include-Extended-Statistics-in-pg_dump.patch | text/x-patch | 13.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2025-12-11 21:55:52 | Re: Extended Statistics set/restore/clear functions. |
| Previous Message | Nathan Bossart | 2025-12-11 21:48:27 | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |