Re: Fix PrivateRefCount hash table key size

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix PrivateRefCount hash table key size
Date: 2025-12-04 16:29:24
Message-ID: aTG25GIkEmyO1wKD@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 02, 2025 at 02:43:25PM +0000, Bertrand Drouvot wrote:
> - hash_ctl.keysize = sizeof(int32);
> + hash_ctl.keysize = sizeof(Buffer);
> hash_ctl.entrysize = sizeof(PrivateRefCountEntry);

LGTM. Appears to be a minor oversight in commit 4b4b680c3d, but it's of no
consequence because Buffer has been a signed 32-bit integer since commit
bdadc9bf1c. Will go commit this.

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2025-12-04 16:30:38 Re: Proposal: Add a callback data parameter to GetNamedDSMSegment
Previous Message Amit Langote 2025-12-04 16:03:44 Re: Segmentation fault on proc exit after dshash_find_or_insert