Re: Remove unused function parameters, part 1: contrib

Hi,

On Thu, Nov 27, 2025 at 02:39:39PM +0300, Kirill Reshke wrote:
> On Thu, 27 Nov 2025 at 11:57, Bertrand Drouvot
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> >
> > For 0005 (collid not used in internal_citext_pattern_cmp()) I think that the
> > unused column should be used (as done in 0005) due to an oversight in commit
> > f2464997644c.
> >
> > This has been done with the help of a coccinelle script. It needs more polishing,
> > so will share later.
> >
> Hi!
> Regarding 0005. collid arg was not used, and nobody ever compiled,
> and then we want to make a change in citext_pattern_cmp behaviour. I
> think we need to at least exercise this code in regression tests.

Thanks for looking at it!

This function is already exercised with the tests added in f2464997644c so that
looks ok to me.

Maybe Jacob or Andrew have some thoughts to share?

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com