| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: Remove unused function parameters, part 1: contrib |
| Date: | 2025-12-01 18:15:48 |
| Message-ID: | CAOYmi+mJHqosCVOwP=K=oyrVszLetsOnYmYGrj9fR2seTauP8w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 27, 2025 at 4:13 AM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> This function is already exercised with the tests added in f2464997644c so that
> looks ok to me.
>
> Maybe Jacob or Andrew have some thoughts to share?
Ooh, blast from the past! You've found my very first Postgres review.
I do not remember it at all. :D
Your v2-0005 looks more correct (and less confusing) to me. I'm not
qualified to comment on the historical behavior of citext+collations.
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-12-01 18:18:13 | Re: split tablecmds.c |
| Previous Message | Jacob Champion | 2025-12-01 17:51:19 | Re: Remove useless casting to the same type |