Re: Extended Statistics set/restore/clear functions.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us
Subject: Re: Extended Statistics set/restore/clear functions.
Date: 2025-11-26 06:16:54
Message-ID: aSabVhUnU8E4VPF7@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 25, 2025 at 11:50:14PM -0600, Corey Huinker wrote:
> So if a function were previously static to one page, but now had utility
> outside of that file, you would then consider changing the function
> signature to add the consts? I ask because this may become relevant with
> the statatt_* functions being moved in the remaining patches.

That's the kind of analysis that requires a case-by-case lookup. The
input functions were not really that worth bothering to me based on
their logic being very isolated. The refactoring pieces with
attribute stats that you are suggesting in 0003 may be indeed more
relevant if done this way.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shlok Kyal 2025-11-26 06:28:41 Re: How can end users know the cause of LR slot sync delays?
Previous Message Hayato Kuroda (Fujitsu) 2025-11-26 06:07:50 [buildfarm related] Machines gcc experimental failed test_lfind