| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Subject: | Re: Extended Statistics set/restore/clear functions. |
| Date: | 2025-11-26 05:50:14 |
| Message-ID: | CADkLM=eLYkp=MUTLeu9C5wawON=+DbYyQedOkSH0fwpLS5m=tQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 25, 2025 at 11:44 PM Michael Paquier <michael(at)paquier(dot)xyz>
wrote:
> On Tue, Nov 25, 2025 at 11:37:09PM -0600, Corey Huinker wrote:
> > I've reviewed what you committed and it looks good to me aside from the
> one
> > nitpick I already made.
>
> I was not really excited about these as it concerns only code local to
> each file where the input functions are located, no routines that are
> actually published for consumption by other parts of the backend.
> --
> Michael
>
So if a function were previously static to one page, but now had utility
outside of that file, you would then consider changing the function
signature to add the consts? I ask because this may become relevant with
the statatt_* functions being moved in the remaining patches.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amul Sul | 2025-11-26 06:02:04 | Re: pg_waldump: support decoding of WAL inside tarfile |
| Previous Message | Michael Paquier | 2025-11-26 05:44:23 | Re: Extended Statistics set/restore/clear functions. |