Re: Add tests for object size limits of injection points

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add tests for object size limits of injection points
Date: 2025-11-12 01:36:54
Message-ID: aRPktttMgyXdQ8ml@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 10, 2025 at 06:27:41PM +0800, Xuneng Zhou wrote:
> Thanks for the patch. I also agree with Chao's suggestion that the
> error message better reflects the actual character limits. I
> implemented a patch for that and updated the test patch as well.
> Please check.

The restriction related to the private area can be enlarged by 1 byte,
because we don't care about the null-termination in this case.

Done that, and adjusted the whole down to 17 where this has been
introduced. It's far from being critical, but consistency could
matter for future changes, including things outside of core. And it's
nice to keep the same rules across the board if we can do so for
testing facilities.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-11-12 01:42:32 Re: Non-blocking archiver process
Previous Message Thomas Munro 2025-11-12 01:36:17 Re: Is this a typo?