Re: Add tests for object size limits of injection points

From: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add tests for object size limits of injection points
Date: 2025-11-12 02:14:16
Message-ID: CABPTF7WAT6vpeZpYBSjxX66y-NV_3Z7ZzCW8pL7UAZyCvTKk1Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Wed, Nov 12, 2025 at 9:37 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Nov 10, 2025 at 06:27:41PM +0800, Xuneng Zhou wrote:
> > Thanks for the patch. I also agree with Chao's suggestion that the
> > error message better reflects the actual character limits. I
> > implemented a patch for that and updated the test patch as well.
> > Please check.
>
> The restriction related to the private area can be enlarged by 1 byte,
> because we don't care about the null-termination in this case.

Makes sense to me.

> Done that, and adjusted the whole down to 17 where this has been
> introduced. It's far from being critical, but consistency could
> matter for future changes, including things outside of core. And it's
> nice to keep the same rules across the board if we can do so for
> testing facilities.
> --
> Michael

Thanks.

--
Best,
Xuneng

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-11-12 02:21:40 Re: Improve logical replication usability when tables lack primary keys
Previous Message Masahiko Sawada 2025-11-12 02:06:10 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart