obsolete autovacuum comment

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: obsolete autovacuum comment
Date: 2025-11-10 20:03:27
Message-ID: aRJFDxKJLFE_1Iai@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

While working on my autovacuum scheduling patch [0], I noticed the
following comment in relation_needs_vacanalyze():

/*
* Note that we don't need to take special consideration for stat
* reset, because if that happens, the last vacuum and analyze counts
* will be reset too.
*/

AFAICT this is a relic from pg_autovacuum (the contrib module and
predecessor to modern autovacuum) [1] and early versions of the autovacuum
patch [2] [3]. After digging through the archives [4], I think this is
referring to some stats that had to be managed separately but weren't ever
actually committed.

Any objections to removing this comment?

[0] https://postgr.es/m/flat/aOaAuXREwnPZVISO%40nathan
[1] https://postgr.es/c/9243664
[2] https://postgr.es/m/attachment/82361/autovacuum-5.patch
[3] https://postgr.es/m/attachment/82371/autovacuum-6.patch
[4] https://postgr.es/m/flat/20050706234302.GA20398%40alvh.no-ip.org

--
nathan

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2025-11-10 20:03:32 Re: GNU/Hurd portability patches
Previous Message Alexander Lakhin 2025-11-10 20:00:01 Re: GNU/Hurd portability patches