| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, ryanzxg(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, Euler Taveira <euler(at)eulerto(dot)com> |
| Subject: | Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18 |
| Date: | 2025-11-01 00:17:25 |
| Message-ID: | aQVRlV6ZOsUz5fd1@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Oct 31, 2025 at 06:50:06PM +0800, Xuneng Zhou wrote:
> On Fri, Oct 31, 2025 at 11:16 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>>
>> On Fri, Oct 31, 2025 at 12:07:01AM +0800, Xuneng Zhou wrote:
>> > Using a wrapper function seems better here.
>>
>> For a cleaner git history, the wrapper function and the assertion
>> should be split as its own commit, with the actual fix applied first.
>> Just an opinion.
>
> It makes sense to me. I've split the patch for HEAD into three patch
> sets. Please see the attached files.
Thanks, that looks sensible. I'll revisit what you have at the
beginning of next week (local Tuesday) with a backpatch down to v13 in
mind. If others have comments and/or objections, please feel free to
chime in.
Note that the changes in 040_standby_failover_slots_sync.pl are not
needed in v3-0001. No need to send an updated patch just for that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2025-11-01 00:44:55 | Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18 |
| Previous Message | Matthias van de Meent | 2025-10-31 11:22:28 | Re: BUG #19098: Can't create unique gist index, where pg_indexes says that WITHOUT OVERLAPS does exacly that |