Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18

Hi,

On Sat, Nov 1, 2025 at 8:17 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Oct 31, 2025 at 06:50:06PM +0800, Xuneng Zhou wrote:
> > On Fri, Oct 31, 2025 at 11:16 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >>
> >> On Fri, Oct 31, 2025 at 12:07:01AM +0800, Xuneng Zhou wrote:
> >> > Using a wrapper function seems better here.
> >>
> >> For a cleaner git history, the wrapper function and the assertion
> >> should be split as its own commit, with the actual fix applied first.
> >> Just an opinion.
> >
> > It makes sense to me. I've split the patch for HEAD into three patch
> > sets. Please see the attached files.
>
> Thanks, that looks sensible. I'll revisit what you have at the
> beginning of next week (local Tuesday) with a backpatch down to v13 in
> mind. If others have comments and/or objections, please feel free to
> chime in.
>
> Note that the changes in 040_standby_failover_slots_sync.pl are not
> needed in v3-0001. No need to send an updated patch just for that.

It's an oversight. Thanks for catching it.

Best,
Xuneng