| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> | 
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> | 
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeremy Schneider <schneider(at)ardentperf(dot)com>, pgsql-hackers(at)postgresql(dot)org | 
| Subject: | Re: another autovacuum scheduling thread | 
| Date: | 2025-10-29 15:51:18 | 
| Message-ID: | aQI39ln_jZ8qorLE@nathan | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
On Tue, Oct 28, 2025 at 05:44:37PM -0500, Sami Imseih wrote:
> My compiler is complaining about v6
> 
> "../src/backend/postmaster/autovacuum.c:3293:32: warning: operation on
> ‘*score’ may be undefined [-Wsequence-point]
>  3293 |                         *score = *score = Max(*score, (double)
> instuples / Max(vacinsthresh, 1));
> [2/2] Linking target src/backend/postgres"
> 
> shouldn't just be like below?
> 
> *score =Max(*score, (double) instuples / Max(vacinsthresh, 1));
Oops. I fixed that typo in v7.
-- 
nathan
| Attachment | Content-Type | Size | 
|---|---|---|
| v7-0001-autovacuum-scheduling-improvements.patch | text/plain | 13.1 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-10-29 15:58:14 | Re: another autovacuum scheduling thread | 
| Previous Message | Peter Eisentraut | 2025-10-29 15:41:16 | Re: C11: should we use char32_t for unicode code points? |