| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoid resource leak (src/test/regress/pg_regress.c) |
| Date: | 2025-10-24 06:03:27 |
| Message-ID: | aPsWrwgFW9yiy60F@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 23, 2025 at 09:37:21PM -0300, Ranier Vilela wrote:
> The function *config_sspi_auth* is responsible for
> rewrite pg_hba.conf and pg_ident.conf to use SSPI authentication.
>
> Coverity complains that the struct addrinfo gai_result is leaked.
> The variable is declared inside block and is not used
> outside the block.
>
> So if the function WSAStartup is successful then the function getaddrinfo
> allocates and fills the struct addrinfo.
>
> The memory must be released at the end of the block.
Not sure that this one is worth caring about. We have a bunch of
allocations that we know would be freed once a binary exits. This is
just one of them, allocated in the context of what is a short-term
execution.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-10-24 06:04:50 | Re: Avoid resource leak (src/bin/pg_resetwal/pg_resetwal.c) |
| Previous Message | Bryan Green | 2025-10-24 06:02:47 | Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows |