Re: Avoid resource leak (src/test/regress/pg_regress.c)

On Fri, 24 Oct 2025, 11:03 Michael Paquier, <michael(at)paquier(dot)xyz> wrote:

> On Thu, Oct 23, 2025 at 09:37:21PM -0300, Ranier Vilela wrote:
> > The function *config_sspi_auth* is responsible for
> > rewrite pg_hba.conf and pg_ident.conf to use SSPI authentication.
> >
> > Coverity complains that the struct addrinfo gai_result is leaked.
> > The variable is declared inside block and is not used
> > outside the block.
> >
> > So if the function WSAStartup is successful then the function getaddrinfo
> > allocates and fills the struct addrinfo.
> >
> > The memory must be released at the end of the block.
>
> Not sure that this one is worth caring about. We have a bunch of
> allocations that we know would be freed once a binary exits. This is
> just one of them, allocated in the context of what is a short-term
> execution.
> --
> Michael
>

Hi!
Yes, this is indeed minor and false positive, but maybe there is still
value in committing this - to silence coverity? There is nothing wrong in
being extra-tidy about memory

>