Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

On Mon, Oct 20, 2025 at 01:07:04PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> Thanks. Here's a new patch set. The v18 patch is just an update to the
>> .abi-compliance-history file that Tom committed. The master patch adds
>> instructions for generating the file to RELEASE_NOTES.
>
> I'd tend to s/placate/control/, otherwise the proposed wording in the
> file looks good. I doubt we really need a script to generate the
> file in the first place -- why wouldn't copying another branch's
> boilerplate be good enough? If you're set on having a script,
> at least make it pre-fill the initial entry. (Using branch HEAD
> ought to be good enough for that.)

I'm fine with leaving out the script if you are. It was only aimed at
making the release checklist a little less cumbersome, but even without the
script it's a whopping minute or two of effort that only needs to happen
once per year. I've probably already spent far more time automating it
than makes sense [0].

>> I imagine we'll
>> want to add .abi-compliance-history files for the back-branches, too
>> (except for perhaps v13, which is about to go out of support in a couple
>> weeks).
>
> Agreed, but let's get v18 in shape first. I imagine the back branches
> will require some effort to fill in the correct reference commits.
> I was expecting we'd commit initial values pointing at the .0 releases
> and then seeing what the ABI checker moans about in each branch ...

Agreed.

[0] https://xkcd.com/1205/

--
nathan