| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "David E(dot) Wheeler" <david(at)justatheory(dot)com>, Mankirat Singh <mankiratsingh1315(at)gmail(dot)com>, pg(at)bowt(dot)ie, andrew(at)dunslane(dot)net, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats() |
| Date: | 2025-10-20 18:30:49 |
| Message-ID: | aPZ_2a1EQvofxeci@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 20, 2025 at 12:14:09PM -0500, Nathan Bossart wrote:
> On Mon, Oct 20, 2025 at 01:07:04PM -0400, Tom Lane wrote:
>> I'd tend to s/placate/control/, otherwise the proposed wording in the
>> file looks good. I doubt we really need a script to generate the
>> file in the first place -- why wouldn't copying another branch's
>> boilerplate be good enough? If you're set on having a script,
>> at least make it pre-fill the initial entry. (Using branch HEAD
>> ought to be good enough for that.)
>
> I'm fine with leaving out the script if you are. It was only aimed at
> making the release checklist a little less cumbersome, but even without the
> script it's a whopping minute or two of effort that only needs to happen
> once per year. I've probably already spent far more time automating it
> than makes sense [0].
Here is an updated patch set.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-notes-for-creating-.abi-compliance-history.patch.master | text/plain | 947 bytes |
| v3-0001-Update-.abi-compliance-history-file.patch.v18 | text/plain | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-10-20 18:39:37 | Skip unregistered custom kinds on stats load |
| Previous Message | Matheus Alcantara | 2025-10-20 18:19:50 | Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue |