Re: [PATCH] Add tests for Bitmapset

On Thu, Oct 09, 2025 at 04:35:55PM +1300, David Rowley wrote:
> On Thu, 9 Oct 2025 at 15:13, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > What do you think about the attached?
>
> Thanks. Looks pretty good.
>
> > + members = palloc(sizeof(int) * num_ops);
>
> Any reason to pfree that and allocate that to the same size as it already was?

No reason. We can shortcut that a bit.

> Wondering if the "members[pos] = members[--num_members];" is worth a
> short comment. Maybe something like: /* zap this member by moving the
> final array member into its place and shrinking the array by 1 */

Yes, a comment can be adapted here. Sounds good to me.
--
Michael