| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Greg Burd <greg(at)burd(dot)me>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-10-09 03:35:55 |
| Message-ID: | CAApHDvpn3bshX+_2t0NbJ263r1etcBdmkROjuJw8DvyZkMcXqg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 9 Oct 2025 at 15:13, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> What do you think about the attached?
Thanks. Looks pretty good.
> + members = palloc(sizeof(int) * num_ops);
Any reason to pfree that and allocate that to the same size as it already was?
Wondering if the "members[pos] = members[--num_members];" is worth a
short comment. Maybe something like: /* zap this member by moving the
final array member into its place and shrinking the array by 1 */
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-10-09 03:46:07 | Re: Enhance Makefiles to rebuild objects on map file changes |
| Previous Message | Michael Paquier | 2025-10-09 03:33:48 | Re: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE |