Re: Improved TAP tests by replacing sub-optimal uses of ok() with better Test::More functions

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Sadhuprasad Patro <b(dot)sadhu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Improved TAP tests by replacing sub-optimal uses of ok() with better Test::More functions
Date: 2025-10-14 08:01:14
Message-ID: aO4DStHELgWaP_z1@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 10, 2025 at 09:33:10AM -0400, Andrew Dunstan wrote:
> Great, I think this is a definite improvement. I saw someone recently
> complaining about this overuse of ok(), so thanks for doing the work to
> improve it.

Yeah, it's really cool to see someone step up and do all this leg
work for the existing code. I have not checked the patch in details
or if there are missing spots. Andrew, is that something you are
planning to do?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-10-14 08:04:12 Re: Executing pg_createsubscriber with a non-compatible control file
Previous Message Peter Smith 2025-10-14 07:51:48 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart