| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Sadhuprasad Patro <b(dot)sadhu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Improved TAP tests by replacing sub-optimal uses of ok() with better Test::More functions |
| Date: | 2025-10-14 20:55:44 |
| Message-ID: | 44303f06-7091-47f2-864a-9da939cb5eb5@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-10-14 Tu 4:01 AM, Michael Paquier wrote:
> On Fri, Oct 10, 2025 at 09:33:10AM -0400, Andrew Dunstan wrote:
>> Great, I think this is a definite improvement. I saw someone recently
>> complaining about this overuse of ok(), so thanks for doing the work to
>> improve it.
> Yeah, it's really cool to see someone step up and do all this leg
> work for the existing code. I have not checked the patch in details
> or if there are missing spots. Andrew, is that something you are
> planning to do?
I believe Sadhuprasad used this recipe to find these:
find src contrib -type f -name '*.p[lm]' -print | \
xargs grep -P '\bok[(].*[~=]'
Maybe that would miss a few, but I bet not too many.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-10-14 21:13:07 | Re: Fix overflow of nbatch |
| Previous Message | Jeff Davis | 2025-10-14 20:45:00 | Re: new environment variable INITDB_LOCALE_PROVIDER |