| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Keisuke Kuroda <keisuke(dot)kuroda(dot)3862(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add support for entry counting in pgstats |
| Date: | 2025-09-25 00:38:55 |
| Message-ID: | aNSPHzt58lA_PO7L@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 24, 2025 at 11:37:25AM +0900, Keisuke Kuroda wrote:
> Regarding the option name track_counts in PgStat_KindInfo.
> In my personal opinion, I was just wondering that it shares
> the same name as the GUC track_counts(pgstat_track_counts in the source code).
> If we want to make it clearer, renaming it to track_entry_counts
> could be one option.
Yes, that's a good point and I have missed the GUC part. What you are
suggesting is cleaner overall with the flag added to the pgstats kind
info.
> (That said, I feel the GUC track_counts option has a mismatch
> between its role and its name...)
I doubt that we will rename this GUC at any point in the future.
Updated patch attached with the new name, as you are suggesting.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-support-for-entry-counting-in-pgstats.patch | text/x-diff | 6.5 KB |
| v2-0002-injection_points-Add-entry-counting.patch | text/x-diff | 4.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2025-09-25 01:01:22 | Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master |
| Previous Message | Bharath Rupireddy | 2025-09-25 00:18:42 | Re: Introduce XID age based replication slot invalidation |