| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Incorrect logic in XLogNeedsFlush() |
| Date: | 2025-09-23 23:25:34 |
| Message-ID: | aNMsboWiuHbUFwmi@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 22, 2025 at 08:09:18AM -0400, Melanie Plageman wrote:
> On Fri, Sep 19, 2025 at 1:28 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> Do we want to make the order of the checks to be more consistent in
>> both routines? These would require a separate set of double-checks
>> and review, but while we're looking at this area of the code we may as
>> tweak it more..
>
> That makes sense to me to avoid future questions such as mine.
Would somebody like to propose a patch? Doing so on this thread would
be OK for me, but perhaps it would be better to discuss that on a new
one as we would deal with a separate problem.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2025-09-23 23:30:40 | Re: libcurl in libpq.pc |
| Previous Message | Michael Paquier | 2025-09-23 23:23:10 | Re: [PATCH] Add tests for Bitmapset |