Re: Incorrect logic in XLogNeedsFlush()

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Incorrect logic in XLogNeedsFlush()
Date: 2025-09-22 12:09:18
Message-ID: CAAKRu_bU=zerA+80xJmCExRMBej2UdKgvtXEV7w8LDE9sqf1rg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 19, 2025 at 1:28 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> Do we want to make the order of the checks to be more consistent in
> both routines? These would require a separate set of double-checks
> and review, but while we're looking at this area of the code we may as
> tweak it more..

That makes sense to me to avoid future questions such as mine.

- Melanie

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2025-09-22 12:27:04 Re: AIX support
Previous Message shveta malik 2025-09-22 11:51:35 Re: Add memory_limit_hits to pg_stat_replication_slots