| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Greg Burd <greg(at)burd(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-09-23 11:07:13 |
| Message-ID: | aNJ_YTuFnMn23PEI@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 23, 2025 at 01:43:47AM -0400, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> The result I had was good enough, so applied. The CI was OK, the
>> buildfarm may have a different opinion.
>
> This patch seems to be rather full of arbitrary casts to or
> from Datum, which is no longer okay. You need to be using
> the appropriate conversion macros, such as PointerGetDatum.
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mamba&dt=2025-09-23%2002%3A12%3A36
Right, this can ve reproduced with a -m32 added to gcc.
I don't see a need for a Datum manipulation in these conversion
macros, as we already allocate the results to and from "text"
before/after using the GETARG or RETURN macros. Using directly
text_to_cstring() and cstring_to_text() takes care of the warnings, as
well.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| test_bitmapset-warnings.patch | text/x-diff | 785 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mihail Nikalayeu | 2025-09-23 11:13:18 | Re: bt_index_parent_check and concurrently build indexes |
| Previous Message | Ashutosh Bapat | 2025-09-23 10:45:14 | Re: Report bytes and transactions actually sent downtream |