| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Greg Burd <greg(at)burd(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-09-23 05:43:47 |
| Message-ID: | 3027069.1758606227@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> The result I had was good enough, so applied. The CI was OK, the
> buildfarm may have a different opinion.
This patch seems to be rather full of arbitrary casts to or
from Datum, which is no longer okay. You need to be using
the appropriate conversion macros, such as PointerGetDatum.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mamba&dt=2025-09-23%2002%3A12%3A36
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-09-23 05:48:24 | Re: SQL:2023 JSON simplified accessor support |
| Previous Message | jian he | 2025-09-23 05:37:44 | Re: let ALTER TABLE DROP COLUMN drop whole-row referenced object |