| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Greg Burd <greg(at)burd(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-10-03 00:42:48 |
| Message-ID: | aN8cCGZYN5oqjMRD@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 03, 2025 at 12:36:57PM +1300, David Rowley wrote:
> I see test_random_operations() is also strict. Is it worth getting rid
> of the SQL NULL checks on the inputs there too? Aka, the attached.
Yes, this was not bothering me much. Anyway, agreed about removing
these as well. I cannot find an argument in favor of making the
function callable on NULL input with default values that are hardcoded
internally in the function.
Thanks, David and Daniel.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-10-03 01:03:06 | Re: Support getrandom() for pg_strong_random() source |
| Previous Message | torikoshia | 2025-10-03 00:31:31 | Re: speedup COPY TO for partitioned table. |