| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Greg Burd <greg(at)burd(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-10-02 23:36:57 |
| Message-ID: | CAApHDvqiN0+mbooUOSCDALc=GoM8DmTbCdvwnCwak6Wb2O1ZJA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 3 Oct 2025 at 01:33, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> Another nitpick would be to remove the test for NULL in test_bms_make_singleton
> since that is a STRICT function, making the test for NULL superfluous code:
I see test_random_operations() is also strict. Is it worth getting rid
of the SQL NULL checks on the inputs there too? Aka, the attached.
David
| Attachment | Content-Type | Size |
|---|---|---|
| test_random_operations_is_strict_no_need_to_check_for_null_inputs.patch | application/octet-stream | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-10-02 23:39:40 | Re: Add memory_limit_hits to pg_stat_replication_slots |
| Previous Message | Masahiko Sawada | 2025-10-02 23:16:43 | Re: Support getrandom() for pg_strong_random() source |