Re: PgStat_HashKey padding issue when passed by reference

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PgStat_HashKey padding issue when passed by reference
Date: 2025-09-19 01:02:00
Message-ID: aMyriM0MIz8t3xlO@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 18, 2025 at 11:52:05AM -0500, Sami Imseih wrote:
> v2 looks good to me. Not sure if there are edge cases in which
> the assert will succeed even with padding (I can't think of any way
> that will be possible), so for now what you have seems good enough.

Okay, I've applied that on HEAD, then. I didn't see an urge in
backpatching it. If there is an ask to do so, I could always do so
later.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-09-19 01:08:02 Re: Resetting recovery target parameters in pg_createsubscriber
Previous Message David Rowley 2025-09-19 00:58:57 Re: REPACK and naming