Re: PgStat_HashKey padding issue when passed by reference

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PgStat_HashKey padding issue when passed by reference
Date: 2025-09-20 01:52:24
Message-ID: CAA5RZ0umevFhNw8m-FqM8cXg8Ke4akR9fG55vkRXaUaQSrX9sw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Thu, Sep 18, 2025 at 11:52:05AM -0500, Sami Imseih wrote:
> > v2 looks good to me. Not sure if there are edge cases in which
> > the assert will succeed even with padding (I can't think of any way
> > that will be possible), so for now what you have seems good enough.
>
> Okay, I've applied that on HEAD, then. I didn't see an urge in
> backpatching it. If there is an ask to do so, I could always do so
> later.
> --
> Michael

Thank you! I update the CF entry [0] as committed.

[0] https://commitfest.postgresql.org/patch/6033/

--
Sami

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-09-20 02:14:25 Re: PgStat_HashKey padding issue when passed by reference
Previous Message Tom Lane 2025-09-20 01:17:24 Re: allow benign typedef redefinitions (C11)