| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve LWLock tranche name visibility across backends |
| Date: | 2025-09-02 14:45:52 |
| Message-ID: | aLcDICmlWJbzsE0k@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 01, 2025 at 10:18:46AM +0000, Bertrand Drouvot wrote:
> Changes look good.
Thanks for looking.
> Not directly related, but I think that we can get rid of:
>
> size = add_size(size, LWLOCK_PADDED_SIZE);
>
> in LWLockShmemSize() and of:
>
> ptr += LWLOCK_PADDED_SIZE - ((uintptr_t) ptr) % LWLOCK_PADDED_SIZE;
>
> in CreateLWLocks(), and just make use of CACHELINEALIGN().
Let's take care of the tranche name stuff first.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2025-09-02 14:54:08 | Re: split func.sgml to separated individual sgml files |
| Previous Message | Nathan Bossart | 2025-09-02 14:43:40 | Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible |