From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Sequence Access Methods, round two |
Date: | 2025-09-01 04:33:45 |
Message-ID: | aLUiKeqm2Lxta7Uz@paquier.xyz |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Aug 21, 2025 at 11:57:58AM +0900, Michael Paquier wrote:
> Yes, that may be useful, but I don't think that this should use the
> psql variable to hide table AMs. I am rebasing a new patch set, v18,
> with a couple of changes:
> - Added your feedback about psql.
> - I have put more thoughts into the code shared between the in-core
> sequence method and the snowflake one, and looked at reducing the
> duplication between the two. At the end, I have introduced a new
> header called sequence_page.h, which is able to reduce the work for
> AMs when these rely on a single page through the addition of macros
> able to initialize and read sequence pages. In this patch set, this
> new part is labelled with 0006.
> - Fixed a few more things, like comments.
Another rebase required due to the business with BufferGetPage() in
710e6c4301ee.
By the way, I have remembered the reason why I have introduced
AT_AddColumnToSequence as a new ALTER TABLE subcommands: ACL check for
sequences. Like views, this simplifies the object type check a lot.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
v19-0001-Integrate-addition-of-attributes-for-sequences-w.patch | text/x-diff | 11.2 KB |
v19-0002-Refactor-code-for-in-core-local-sequences.patch | text/x-diff | 54.5 KB |
v19-0003-Sequence-access-methods-backend-support.patch | text/x-diff | 64.6 KB |
v19-0004-Sequence-access-methods-dump-restore-support.patch | text/x-diff | 21.8 KB |
v19-0005-Sequence-access-methods-core-documentation.patch | text/x-diff | 9.5 KB |
v19-0006-Refactor-logic-for-page-manipulations-of-sequenc.patch | text/x-diff | 7.8 KB |
v19-0007-snowflake-Add-sequence-AM-based-on-it.patch | text/x-diff | 25.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Zhijie Hou (Fujitsu) | 2025-09-01 04:45:26 | RE: Conflict detection for update_deleted in logical replication |
Previous Message | Alexandra Wang | 2025-09-01 04:11:08 | Re: SQL:2023 JSON simplified accessor support |