Re: Sequence Access Methods, round two

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Sequence Access Methods, round two
Date: 2025-08-21 02:57:58
Message-ID: aKaLNho5lOsdr5qw@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 19, 2025 at 10:14:33AM +0500, Kirill Reshke wrote:
> I played with patch sets some more, trying to break things in nasty
> ways (something like CREATE OPERATOR FAMILY ff USING seqlocal or other
> incorrect ddl).
> But I had no success. I will try some more later, maybe I will find something

Thanks.

> PFA diff which describes the access method of sequence on \d+ psql
> meta-command likewise we do it for tables.

Yes, that may be useful, but I don't think that this should use the
psql variable to hide table AMs. I am rebasing a new patch set, v18,
with a couple of changes:
- Added your feedback about psql.
- I have put more thoughts into the code shared between the in-core
sequence method and the snowflake one, and looked at reducing the
duplication between the two. At the end, I have introduced a new
header called sequence_page.h, which is able to reduce the work for
AMs when these rely on a single page through the addition of macros
able to initialize and read sequence pages. In this patch set, this
new part is labelled with 0006.
- Fixed a few more things, like comments.
--
Michael

Attachment Content-Type Size
v18-0001-Integrate-addition-of-attributes-for-sequences-w.patch text/x-diff 11.2 KB
v18-0002-Refactor-code-for-in-core-local-sequences.patch text/x-diff 54.5 KB
v18-0003-Sequence-access-methods-backend-support.patch text/x-diff 64.6 KB
v18-0004-Sequence-access-methods-dump-restore-support.patch text/x-diff 21.8 KB
v18-0005-Sequence-access-methods-core-documentation.patch text/x-diff 9.5 KB
v18-0006-Refactor-logic-for-page-manipulations-of-sequenc.patch text/x-diff 7.8 KB
v18-0007-snowflake-Add-sequence-AM-based-on-it.patch text/x-diff 25.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message jian he 2025-08-21 02:53:27 Re: Add SPLIT PARTITION/MERGE PARTITIONS commands