Re: Unused parameter in ProcessSlotSyncInterrupts()

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: cca5507 <cca5507(at)qq(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Unused parameter in ProcessSlotSyncInterrupts()
Date: 2025-08-29 15:04:13
Message-ID: aLHBbYv52F7ipoer@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 29, 2025 at 10:40:25PM +0800, cca5507 wrote:
> When reading the code about slot sync, I find the $subject, attach a
> patch to fix it.

LGTM. I looked through the original thread [0] for clues about the origins
of this parameter, but it's a very long thread, and ctrl+f didn't help. It
seems to have become unused somewhere between v82 and v88 of the patch set,
though. In v82, ProcessSlotSyncInterrupts() has the following code:

+ if (ShutdownRequestPending)
+ {
+ if (wrconn)
+ walrcv_disconnect(wrconn);
+ ereport(LOG,
+ errmsg("replication slot sync worker is shutting down on receiving SIGINT"));
+ proc_exit(0);
+ }

[0] https://postgr.es/m/514f6f2f-6833-4539-39f1-96cd1e011f23%40enterprisedb.com

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2025-08-29 15:12:36 aio/README.md comments
Previous Message Bertrand Drouvot 2025-08-29 15:02:23 Generate pgstat_count_slru*() functions for slru using macros