aio/README.md comments

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: aio/README.md comments
Date: 2025-08-29 15:12:36
Message-ID: a11d04194afcc25c90d356ca11a75c8f2dbc1a8e.camel@j-davis.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


aio/README.md:

* In the section "### IO can be started in critical sections", the
first paragraph seems like it belongs in another section.

* The README generally mixes design goals with implemented
functionality. For instance, we're only using it on the read path
currently, but the README mentions WAL writing several times. We should
probably clarify that a bit.

* "`io_method=sync` does not actually perform AIO but allows to use the
AIO API while performing synchronous IO. This can be useful for
debugging." Sync is still useful for cases where the shared buffers are
a small fraction of system memory, right?

* "Particularly on modern storage..." I assume this is talking about
SSDs, but it could also mean some kind of network block storage. If our
architecture is changing in response to new real-world hardware, we
should briefly try to connect the design choices to assumptions about
hardware, where appropriate.

Regards,
Jeff Davis

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-08-29 15:55:46 Re: BUG #18959: Name collisions of expression indexes during parallel Index creations on a pratitioned table.
Previous Message Nathan Bossart 2025-08-29 15:04:13 Re: Unused parameter in ProcessSlotSyncInterrupts()