| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Don't treat virtual generated columns as missing statistics in vacuumdb --missing-stats-only |
| Date: | 2025-08-21 13:56:48 |
| Message-ID: | aKcloCjqAfb-9Nl6@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 21, 2025 at 11:13:44AM +0900, Fujii Masao wrote:
> On Thu, Aug 21, 2025 at 4:19 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>> Nice find. I would suggest adding the virtual generated column to
>> regression_vacuumdb_test when it is first created so that we can just rely
>> on the existing test cases. In fact, by doing so, you'll see that we need
>> a similar change to the "inheritance and regular stats" part of the query.
>
> +1
Since we're running out of time for v18, I went ahead and updated the
patch. I've also added an open item for this.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-vacuumdb-Fix-missing-stats-only-with-virtual-gene.patch | text/plain | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2025-08-21 14:10:43 | Remove unneeded cast in heap_xlog_lock. |
| Previous Message | Ashutosh Bapat | 2025-08-21 13:56:41 | Re: Report reorder buffer size |