Re: Don't treat virtual generated columns as missing statistics in vacuumdb --missing-stats-only

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Don't treat virtual generated columns as missing statistics in vacuumdb --missing-stats-only
Date: 2025-08-21 15:29:56
Message-ID: CADkLM=ceJpMmq-wO5=FkPLMUo01aWW=FJvP37YDdWjMHXJnbFQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 21, 2025 at 9:56 AM Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:

> On Thu, Aug 21, 2025 at 11:13:44AM +0900, Fujii Masao wrote:
> > On Thu, Aug 21, 2025 at 4:19 AM Nathan Bossart <nathandbossart(at)gmail(dot)com>
> wrote:
> >> Nice find. I would suggest adding the virtual generated column to
> >> regression_vacuumdb_test when it is first created so that we can just
> rely
> >> on the existing test cases. In fact, by doing so, you'll see that we
> need
> >> a similar change to the "inheritance and regular stats" part of the
> query.
> >
> > +1
>
> Since we're running out of time for v18, I went ahead and updated the
> patch. I've also added an open item for this.
>

+1 on the fix, works for me.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-08-21 15:37:10 Re: Don't treat virtual generated columns as missing statistics in vacuumdb --missing-stats-only
Previous Message Tom Lane 2025-08-21 15:27:59 Re: misleading error message in ProcessUtilitySlow T_CreateStatsStmt