Re: Wrong datatype used in visibilitymap_get_status

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, robertmhaas(at)gmail(dot)com, sawada(dot)mshk(at)gmail(dot)com
Subject: Re: Wrong datatype used in visibilitymap_get_status
Date: 2025-07-24 22:11:15
Message-ID: aIKvg42Jx4jODLIy@jrouhaud
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 24, 2025 at 09:56:00AM -0500, Nathan Bossart wrote:
> On Thu, Jul 24, 2025 at 03:50:17PM +0800, Julien Rouhaud wrote:
> > I was reading the visibility map code and noticed that
> > visibilitymap_get_status() wasn't updated in a892234f830e AFAICS (Cc Robert and
> > Sawada-san) to return an empty set of flags rather than false in one code path,
> > so simple patch attached. Both have the same value so that likely explains why
> > it got unnoticed until now, although I assume that some compiler would
> > have eventually started to complain about that.
>
> +1, I'll go commit this.

Thanks.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2025-07-24 22:22:12 Re: PG 18 beta1 release notes misses mention of pg_noreturn
Previous Message Joel Jacobson 2025-07-24 22:04:31 Re: Interrupts vs signals