Re: Wrong datatype used in visibilitymap_get_status

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, robertmhaas(at)gmail(dot)com, sawada(dot)mshk(at)gmail(dot)com
Subject: Re: Wrong datatype used in visibilitymap_get_status
Date: 2025-07-24 14:56:00
Message-ID: aIJJgOWHXfNQYJjz@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 24, 2025 at 03:50:17PM +0800, Julien Rouhaud wrote:
> I was reading the visibility map code and noticed that
> visibilitymap_get_status() wasn't updated in a892234f830e AFAICS (Cc Robert and
> Sawada-san) to return an empty set of flags rather than false in one code path,
> so simple patch attached. Both have the same value so that likely explains why
> it got unnoticed until now, although I assume that some compiler would
> have eventually started to complain about that.

+1, I'll go commit this.

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2025-07-24 14:57:42 Commitfest 2025-03 still has active patches
Previous Message Peter Geoghegan 2025-07-24 14:40:12 Re: index prefetching