| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: Custom pgstat support performance regression for simple queries |
| Date: | 2025-07-23 07:33:09 |
| Message-ID: | aICQNfYF1ldIf7hp@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Wed, Jul 23, 2025 at 09:54:12AM +0900, Michael Paquier wrote:
> Then, about the loop used here, I'd be OK to keep the past shortcuts
> for the builtin fixed-sized stats kinds with the requirement that new
> builtin stats kinds need to hack into pgstat_report_stat() themselves
> on efficiency grounds
Maybe we could use a flag, say:
#define PGSTAT_PENDING_IO (1 << 0)
#define PGSTAT_PENDING_WAL (1 << 1)
#define PGSTAT_PENDING_SLRU (1 << 2)
and check for a pgstat_pending_mask in pgstat_report_stat() instead?
They would need to set pgstat_pending_mask accordingly when they flush, have
pending stats though.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2025-07-23 07:42:33 | Re: Interrupts vs signals |
| Previous Message | Zhijie Hou (Fujitsu) | 2025-07-23 07:23:42 | RE: Conflict detection for update_deleted in logical replication |