Re: pgsql: injection_points: Add injection_points_list()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: injection_points: Add injection_points_list()
Date: 2025-07-13 02:21:20
Message-ID: aHMYILre3-FgticE@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Jul 10, 2025 at 01:24:48PM +0300, Aleksander Alekseev wrote:
> In injection_points_list() isn't `memset(values, 0, sizeof(values))`
> redundant?

Yes, I'm just finding this to be a cleaner practice.

> Also perhaps we want to pfree inj_points.

This is freed with the memory context of the function, so any way is
fine IMO.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2025-07-13 07:53:34 pgsql: libpq: Add "servicefile" connection option
Previous Message Nathan Bossart 2025-07-12 19:35:24 pgsql: Remove XLogCtl->ckptFullXid.