Re: pgsql: injection_points: Add injection_points_list()

From: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Cc: Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: pgsql: injection_points: Add injection_points_list()
Date: 2025-07-10 10:24:48
Message-ID: CAJ7c6TOVA-DPdK9pL5OGnap1rvj+y-hgYwgTMmpjUQvdrGNThA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Michael,

> injection_points: Add injection_points_list()
>
> This function can be used to retrieve the information about all the
> injection points attached to a cluster, providing coverage for
> InjectionPointList() introduced in 7b2eb72b1b8c.
>
> The original proposal turned around a system function, but that would
> not be backpatchable to stable branches. It was also a bit weird to
> have a system function that fails depending on if the build allows
> injection points or not.

In injection_points_list() isn't `memset(values, 0, sizeof(values))`
redundant? Also perhaps we want to pfree inj_points.

These are minor issues of course.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Jacob Champion 2025-07-10 17:21:51 Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.
Previous Message Michael Paquier 2025-07-10 03:55:25 Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.