From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Remove unused wait_event_info parameter in FileStartReadV() |
Date: | 2025-07-04 09:46:55 |
Message-ID: | aGejD8i8aj4amY7m@ip-10-97-1-34.eu-west-3.compute.internal |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi hackers,
While working on wait events related stuff, I noticed that the wait_event_info
parameter in FileStartReadV() is unused.
The unused parameter is there since 50cb7505b301, and I think it's ok to just
remove it (as it is set correctly in pgaio_io_perform_synchronously()).
PFA, a patch doing so.
BTW, out of curiosity I launched:
run-clang-tidy -checks="-*,misc-unused-parameters" | grep -c "warning: parameter.*is unused"
2008
That's quite a lot, but I did look at some of them randomly and they were
coming from callbacks (which can make sense). That might need a deeper analysis
though (to check if there are some outside of the callback cases).
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Attachment | Content-Type | Size |
---|---|---|
v1-0001-Remove-unused-wait_event_info-parameter-in-FileSt.patch | text/x-diff | 2.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Aleksander Alekseev | 2025-07-04 10:16:02 | Re: Remove unused wait_event_info parameter in FileStartReadV() |
Previous Message | Yura Sokolov | 2025-07-04 09:25:03 | Re: Add 64-bit XIDs into PostgreSQL 15 |