Re: Remove unused wait_event_info parameter in FileStartReadV()

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Subject: Re: Remove unused wait_event_info parameter in FileStartReadV()
Date: 2025-07-04 10:16:02
Message-ID: CAJ7c6TNmLSqdaELJfdvRZJDpQU+hfi+yphJA4=gr8RU5GCX0tQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Bertrand,

> While working on wait events related stuff, I noticed that the wait_event_info
> parameter in FileStartReadV() is unused.
>
> The unused parameter is there since 50cb7505b301, and I think it's ok to just
> remove it (as it is set correctly in pgaio_io_perform_synchronously()).

Any chance we should call pgstat_report_wait_start(wait_event_info)
instead similarly to other functions in fd.c?

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2025-07-04 10:23:37 Re: Logical Replication of sequences
Previous Message Bertrand Drouvot 2025-07-04 09:46:55 Remove unused wait_event_info parameter in FileStartReadV()