Re: Add pg_get_injection_points() for information of injection points

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Rahila Syed <rahilasyed90(at)gmail(dot)com>
Cc: Aleksander Alekseev <aleksander(at)timescale(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kirill Reshke <reshkekirill(at)gmail(dot)com>
Subject: Re: Add pg_get_injection_points() for information of injection points
Date: 2025-07-04 06:29:07
Message-ID: aGd0s0R3rgWcX0YM@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 03, 2025 at 12:14:55PM +0530, Rahila Syed wrote:
>> Now for the second part with the SRF making the injection point
>> information available at SQL level. The point about adding the new
>> function in the core engine has been sticky, and I'm coming down to
>> the conclusion that I'd still want to make this stuff backpatchable if
>> need be in the future. So let's just add a new function in the test
>> module injection_points and call it a day.
>
> Do you plan to document this function anywhere where it would be more
> visible to those who might want to use it in their tests?

It's a bit larger than just this function, as we have never exposed
any of the test modules in the docs. Perhaps we could just add a line
in the section for injection points for this case. At the end, I
don't want these additions to be an extra documentation burden if one
wants to add more tools, which may be in the scope of a bug fix as
that would just cause extra work.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2025-07-04 06:31:24 Re: Conflict detection for update_deleted in logical replication
Previous Message Michael Paquier 2025-07-04 06:13:18 Re: A assert failure when initdb with track_commit_timestamp=on